Feat/shadow #412
Merged
Feat/shadow #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. create shadow tables in init.sql & sharding.sql 2. hide shadow tables for "show tables" command 3. impl shadow match hint rule (only select) 4. support shadow type match regex (only select)
add integration test for shadow tables
1. impl shadow match hint rule (insert/update/delete) 2. support shadow type match regex (insert/update/delete) 3、integrate test
Lvnszn
reviewed
Sep 15, 2022
Comment on lines
96
to
105
| /* | ||
| for _, sqlCase := range cases.ExShRegexCases { | ||
| for _, sense := range sqlCase.Sense { | ||
| if strings.Compare(strings.TrimSpace(sense), "shadow") == 0 { | ||
| params := strings.Split(sqlCase.Parameters, ",") | ||
| args := make([]interface{}, 0, len(params)) | ||
| for _, param := range params { | ||
| k, _ := test.GetValueByType(param) | ||
| args = append(args, k) | ||
| } |
There was a problem hiding this comment.
并不是无用，hint模式和regex模式的yaml配置只能生效一个，ExShHintCases是给hint模式的配置用的，ExShRegexCases是给regex模式的配置用的。默认配置是hint模式，所以就注释掉了ExShRegexCases，如果修改配置文件，就能用到这部分代码了
Lvnszn
reviewed
Sep 15, 2022
| sense: | ||
| - shadow | ||
| expected: | ||
| type: "rowAffect" | ||
| value: 0 | ||
| value: 1 |
There was a problem hiding this comment.
哪个地方？我是按case组来换行的，如果每个case都换行的，似乎不好看
Lvnszn
reviewed
Sep 15, 2022
pkg/runtime/optimize/dml/delete.go
Outdated
| //first shadow_rule, and then sharding_rule | ||
| if o.ShadowRule != nil && !matchShadow { | ||
| if matchShadow, err = (*optimize.ShadowSharder)(o.ShadowRule).Shard(stmt.Table, constants.ShadowDelete, stmt.Where, o.Args...); err != nil { | ||
| return nil, errors.Wrap(err, "calculate shards failed") |
There was a problem hiding this comment.
calculate shadow shards failed 会不会更直接点
There was a problem hiding this comment.
多个shadow规则并存时采用优先方案还是排它方案，相对来说，优先方案省事一些，而且逻辑上也比较清晰
Lvnszn
approved these changes
Sep 15, 2022
modify error messages and comments
ignore parameters temporary
dongzl
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: support shadow type match regex #365:
3、integrate test
Test Cases:
[hint mode]
/*A! shadow(shadow) */ INSERT INTO student(id,uid,score,name,nickname,gender,birth_year) values (1,3,100,'lilei','shadow test',1,1980);
/*A! shadow(shadow) */ SELECT * FROM student WHERE uid = 3;
/*A! shadow(shadow) */ UPDATE student SET score = 98 WHERE uid = 3;
/*A! shadow(shadow) */ DELETE FROM student WHERE uid = 3;
[regex mode]
INSERT INTO student(id,uid,score,name,nickname,gender,birth_year) values (1,2,100,'hanmeimei','shadow test',1,1981);
SELECT * FROM student WHERE uid = 2 AND name = 'hanmeimei';
UPDATE student SET score = 98 WHERE uid = 2 AND name = 'hanmeimei';
DELETE FROM student WHERE uid = 2 AND name = 'hanmeimei';
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: